Hacker GitHub

← All repos

google/eng-practices

View on GitHub ↗ ★ 23,278 archived

Google's Engineering Practices documentation

11 mentions on Hacker News by 11 people: 5 stories, 6 comments · first 2019-09-06 · latest 2026-01-02

Mentions per year 11 mentions · busiest year 2019 (4)
20082026
AllStoriesComments NewestTopOldest
  1. …sloppy commit history. Sure, sometimes it's correct to squash, but for nontrivial changes I go with https://github.com/google/eng-practices/blob/master/review/d...
    comment by thomashabets2 · 2026-01-02 · in Pre-commit hooks are broken
  2. I consider this document to be the golden standard for reviews, for both parties involved: https://github.com/google/eng-practices/blob/master/review%2...
    comment by occz · 2024-08-21 · in Code review antipatterns
  3. …code review. Other organizations often call this a "change", "patch", or "pull-request". [0] https://github.com/google/eng-practices
    comment by Terr_ · 2023-12-07 · in Google calls Drive data loss "fixed," locks forum threads saying otherwise
  4. …Only certain engineers can approve reviews and trigger the patch being applied to the trunk. https://github.com/google/eng-practices Many of the others also have variations, but unlikely that any organisation with 1000+ engineers has a…
    comment by wyaeld · 2021-07-16 · in On the evilness of feature branching
  5. Here is some documentation about how google does their reviews. I think it is pretty good https://github.com/google/eng-practices/blob/master/review/r...
    comment by muffa · 2021-03-11 · in Looking for samples of great PR reviews
  6. ▲ 4
    Google Engineering Best Practices
    story by Lilian_Lee · 2020-05-11 · 0 comments
  7. ▲ 2
    Google Engineering Practices: Code Reviews Should Be Fast
    story by hharnisch · 2020-01-02 · 0 comments
  8. ▲ 2
    Google Engineering Practices Documentation
    story by lorenzotenti · 2019-09-10 · 0 comments
  9. ▲ 2
    Google Engineering Practices Documentation
    story by kaushikt · 2019-09-09 · 0 comments
  10. ▲ 2
    Google's Code Review Guidelines
    story by yvonnick · 2019-09-06 · 0 comments
  11. They're accepting pull requests: https://github.com/google/eng-practices/pulls?q=is%3Apr+is%3...
    comment by dymk · 2019-09-06 · in How to do a code review