Hacker GitHub

← All repos

github/cmark-gfm

View on GitHub ↗ ★ 1,142 C

GitHub's fork of cmark, a CommonMark parsing and rendering library and program in C

8 mentions on Hacker News by 8 people: 2 stories, 6 comments · first 2018-10-17 · latest 2022-03-04

Mentions per year 8 mentions · busiest year 2021 (3)
20082026
AllStoriesComments NewestTopOldest
  1. the actual commit fix has some comments that may be useful for understanding: https://github.com/github/cmark-gfm/commit/ac80f7b56522ffa15...
    comment by phillmv · 2022-03-04 · in Heap memory corruption in GitHub's Markdown table parsing extension
  2. This seems to be the patch: https://github.com/github/cmark-gfm/commit/cf7577d2f74289cb8... Integer overflow can happen in Rust, but it's well-defined, not undefined. This helps. Bounds checking is part of indexing, and so even if an index…
    comment by steveklabnik · 2022-03-04 · in Heap memory corruption in GitHub's Markdown table parsing extension
  3. Actually it was implemented in Nov 2017, but only deployed/enabled for GitHub Pages. https://github.com/github/cmark-gfm/pull/64 See this comment: https://github.com/github/cmark-gfm/pull/64#issuecomment-401...
    comment by eevilspock · 2021-09-30 · in Footnotes now supported in GitHub Markdown
  4. Yes, simply look at the latest release which contains three bugfixes related to footnotes: https://github.com/github/cmark-gfm/releases/tag/0.29.0.gfm....
    comment by OJFord · 2021-09-30 · in Footnotes now supported in GitHub Markdown
  5. Is this implemented in cmark-gfm? https://github.com/github/cmark-gfm
    comment by eslaught · 2021-09-30 · in Footnotes now supported in GitHub Markdown
  6. …but it doesn't render in the rendered markdown because there's a bug in Gitlab's markdown renderer: https://github.com/github/cmark-gfm/issues/121 (see also https://gitlab.com/gitlab-org/gitlab-ce/issues/52013 )
    comment by tonyg · 2019-08-09 · in Preserves: An Expressive Data Language