firoorg/firo
View on GitHub ↗ ★ 803 C++
The privacy-focused cryptocurrency
10 mentions on Hacker News by 9 people: 0 stories, 10 comments · first 2017-02-17 · latest 2017-03-07
20082026
-
I think that won't even compile due to an accidentally pasted URL here: https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7fe...
comment by unbeli · 2017-03-07 · in Zcoin implementation bug enabled attacker to create over 500K Zcoins -
The commit that fixes it does not change any tests: https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7fe... This indicates that the code in question is not covered by tests. I work on a database, for which correctness is paramount,…
comment by electrum · 2017-03-07 · in Zcoin implementation bug enabled attacker to create over 500K Zcoins -
The error is here: https://github.com/zcoinofficial/zcoin/blob/81a667867b5d8489... and the line of code: zccoinSpend.denomination == libzerocoin::ZQ_LOVELACE; In other words, a statement with no effect. In D, such a line gives an error,…
comment by WalterBright · 2017-03-07 · in Zcoin implementation bug enabled attacker to create over 500K Zcoins -
I think the single character fix is this [1], GP seems to be describing [2]. [1] https://github.com/zcoinofficial/zcoin/commit/b20c177032de3c... [2] https://github.com/zcoinofficial/zcoin/commit/33796c839f7d4d...
comment by taspeotis · 2017-02-18 · in Zerocoin implementation bug -
…clear, this is about Zcoin, not Zcash/Zerocash. The two are completely different) The fix is here. https://github.com/zcoinofficial/zcoin/commit/33796c839f7d4d... What happened? First, some stylized facts about ZCoin: 0) ZCoin is a fork of…
comment by ianmiers · 2017-02-18 · in Zerocoin implementation bug -
Nope this -- 4 commits later, and 12 minutes ago at this time. https://github.com/zcoinofficial/zcoin/commit/b20c177032de3c...
comment by emmelaich · 2017-02-18 · in Zerocoin implementation bug -
…constants first! i.e. if (someconstant == somevar) { ... [edit: nope, looks like this is it] https://github.com/zcoinofficial/zcoin/commit/b20c177032de3c...
comment by emmelaich · 2017-02-18 · in Zerocoin implementation bug -
Actually I think this might have been the fix. https://github.com/zcoinofficial/zcoin/commit/584e1c60617d59...
comment by w-ll · 2017-02-18 · in Zerocoin implementation bug -
…look at commits. I am not familiar with their code base, but latest commit seems like a bugfix: https://github.com/zcoinofficial/zcoin/commit/33796c839f7d4d...
comment by ycmbntrthrwaway · 2017-02-17 · in Zerocoin implementation bug -
…I took a glance at their Github bug tracker and couldn't find any references to this bug. [0] https://github.com/zcoinofficial/zcoin/issues?q=is%3Aissue+i...
comment by desdiv · 2017-02-17 · in Zerocoin implementation bug