signalapp/Signal-Android on Hacker News

…transparency and the ability for all to interrogate the code. They already do all of those things. https://github.com/signalapp/Signal-Android

comment by asdfasgasdgasdg · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…have prevented this. Or maybe there should be a database per conversation (set of all parties). https://github.com/signalapp/Signal-Android/commit/83086a5a2... https://github.com/signalapp/Signal-Android/commit/b9657208f... Row IDs…

comment by seg_lol · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…something usable. Hopefully Matrix will be able to provide something as easily usable as well. [0]: https://github.com/signalapp/Signal-Android/issues/10247#iss... [1]: https://github.com/signalapp/Signal-Android/commit/83086a5a2... [2]:…

comment by Popegaf · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…commit that fixes it? If I understand the issue [0] correctly, these two commits should be the fix: https://github.com/signalapp/Signal-Android/commit/e90fa05d6... https://github.com/signalapp/Signal-Android/commit/b9657208f... The former…

comment by tomudding · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…fixed at 7/21 on the original thread and this main one, this issue was still open for months. [0] https://github.com/signalapp/Signal-Android/issues/11137 [1] https://github.com/signalapp/Signal-Android/issues/10247

comment by colesantiago · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…issue opened December last year, that's still quite a lot of time before a fix could be found. [1] https://github.com/signalapp/Signal-Android/commit/a47448b6c...

comment by jeroenhd · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

No PR with name that would suggest the fix in the client https://github.com/signalapp/Signal-Android/pulls?q=is%3Apr+... and no PR from OP in the opensource part of the server https://github.com/signalapp/Signal-Server/pulls?q=is%3Apr+i...

comment by agilob · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…an app used by millions, but they probably need to figure out a better way to triage... [1] https://github.com/signalapp/Signal-Android/issues/11137

comment by rococode · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…platforms like Telegram that has hundreds of employees or WhatsApp with far more than that? [1] https://github.com/signalapp/Signal-Android/graphs/contribut...

comment by godelski · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

Fixed on 7/21. Forgot to close the issue: https://github.com/signalapp/Signal-Android/issues/10247

comment by tag2103 · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…this was fixed [1]. Doesn't fill me with confidence if this type of issue can occur though. [1] https://github.com/signalapp/Signal-Android/issues/10247#iss...

comment by lwhi · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

Fixed: https://github.com/signalapp/Signal-Android/issues/10247#iss...

comment by jayavanth · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…to it, as if i have sent that image to him, even though that image is not even present on my phone. https://github.com/signalapp/Signal-Android/issues/10247#iss... Yikes. > [..] I've also recently had a probably unrelated issue where my…

comment by johnchristopher · 2021-07-25 · in Signal on Android: Images sent to wrong contacts

…updated during this period. Signal responded to the server code being outdated as well: https://github.com/signalapp/Signal-Android/issues/11101#iss...

comment by decrypt · 2021-07-19 · in Cryptographers unearth vulnerabilities in Telegram's encryption protocol

…client you downloaded from Play Store hasn't been tampered with. Instructions for that are here: https://github.com/signalapp/Signal-Android/tree/master/repr... Your post is slightly ironic, considering Telegram doesn't give you any choice…

comment by maqp · 2021-07-18 · in Cryptographers unearth vulnerabilities in Telegram's encryption protocol

Which in theory Signal supports; anyone tried it lately ? https://github.com/signalapp/Signal-Android/tree/master/repr...

comment by Aissen · 2021-07-02 · in Google Play Dumps APKs for the More Google-Controlled “Android App Bundle”

…registered on the EventBus? Oh look, it's a file that is just instantiating a bajillion classes: ( https://github.com/signalapp/Signal-Android/blob/master/app/... ) Because dependency injection is stupid on GUI applications, and it messes…

comment by an_opabinia · 2021-06-19 · in EventBus 3.1 with plain Java support

I raised a similar issue 4 years ago - https://github.com/signalapp/Signal-Android/issues/6703 Signal used to silently fail if you changed device. I guess not much has changed.

comment by edent · 2021-06-05 · in Valid Signal privacy issues shrugged off while patches quietly rolled out

Source? This page says otherwise: https://github.com/signalapp/Signal-Android/tree/master/repr...

comment by gruez · 2021-04-28 · in Grand jury subpoena for Signal user data, Central District of California

…they copied from Silhouette ( https://news.ycombinator.com/item?id=26842183 ) also copied from https://github.com/signalapp/Signal-Android/issues/11160#iss... , and probably other places too. I asked them to stop (…

comment by dang · 2021-04-17 · in Corrupt Signal DB issue crashing App and losing data

…MRENCLAVE value is the one on line 123, compare the signature of the `KbsEnclave` constructor -> https://github.com/signalapp/Signal-Android/blob/7394b4ac277...

comment by codethief · 2021-04-09 · in Signal Server code on GitHub is up to date again

…wanted to find out whether it gets pinned or whether Signal trusts a CA. It seems to be the latter: https://github.com/signalapp/Signal-Android/blob/6ddfbcb9451... For completeness, let's also have a look at where the CA certificate(s)…

comment by codethief · 2021-04-08 · in Signal Server code on GitHub is up to date again

…people interested in this matter: I've followed the path of the MRENCLAVE variable to the very end, https://github.com/signalapp/Signal-Android/blob/6ddfbcb9451... where it gets injected by the build config. The build config, in turn, is…

comment by codethief · 2021-04-08 · in Signal Server code on GitHub is up to date again

…the MRENCLAVE value is valid. The code where the verifier is verifying the IAS signature is here: https://github.com/signalapp/Signal-Android/blob/6ddfbcb9451... The code where the MRENCLAVE value is checked is here:…

comment by corbiqula · 2021-04-08 · in Signal Server code on GitHub is up to date again

…running on the servers. Unfortunately, `rg -i SGX` only yielded the following two pieces of code: https://github.com/signalapp/Signal-Android/blob/master/libs... https://github.com/signalapp/Signal-Android/blob/master/libs... No immediate…

comment by codethief · 2021-04-07 · in Signal Server code on GitHub is up to date again

…nothing shady, and it's only used when you're in Egypt, UAE, Oman, Qatar, or Iran. Have a look at https://github.com/signalapp/Signal-Android/blob/d74e9f74103... vs https://github.com/signalapp/Signal-Android/blob/d74e9f74103... and,…

comment by codethief · 2021-04-07 · in Signal adds a payments feature with a privacy-focused cryptocurrency

Nothing to see here, people, this has been already reported as a bug and hopefully be fixed soon: https://github.com/signalapp/Signal-Android/issues/11177

comment by knocte · 2021-04-07 · in Et Tu, Signal?

…mechanic. When built for the website the build config `PLAY_STORE_DISABLED` set to true. https://github.com/signalapp/Signal-Android/blob/1f578ebd2c1...

comment by fX0rObfoMN4 · 2021-04-07 · in Signal adds a payments feature with a privacy-focused cryptocurrency

…without Google Play Services (to be sure that it's not Google Play noise you're observing) [4]. [1] https://github.com/signalapp/Signal-Android/blob/d74e9f74103... [2] https://github.com/LibreSignal/LibreSignal/issues/37 [3]…

comment by cookiengineer · 2021-04-07 · in Signal adds a payments feature with a privacy-focused cryptocurrency

…party receives your backed up private keys? Why do you trust Google more than Facebook? [1] [1] https://github.com/signalapp/Signal-Android/blob/d74e9f74103... I'm not trying to troll here. I'm trying to point out that babbling about…

comment by cookiengineer · 2021-04-07 · in Signal adds a payments feature with a privacy-focused cryptocurrency

You have a fix waiting as a PR for what could be OP's issue: https://github.com/signalapp/Signal-Android/pull/11134

comment by hiq · 2021-04-06 · in It looks like Signal isn't as open source as you thought it was anymore

…listed in our repo[1]? The steps use the very same docker image we use to build our releases. [1] https://github.com/signalapp/Signal-Android/tree/master/repr...

comment by greysonp · 2021-04-06 · in It looks like Signal isn't as open source as you thought it was anymore

…the first reference to the commit: https://github.com/search?q=365ad3a4f821a9e2393c5a3e1522b2c0... https://github.com/signalapp/Signal-Android/issues/11101#iss... The article was published at 2021-04-06 17:50 UTC. The first reference on…

comment by shaicoleman · 2021-04-06 · in It looks like Signal isn't as open source as you thought it was anymore

It looks like they are, but there might be a minor issue in verifying the content: https://github.com/signalapp/Signal-Android/issues/10476 But despite best efforts by the community to verify builds, Google and Apple can be forced to…

comment by ndiscussion · 2021-04-06 · in It looks like Signal isn't as open source as you thought it was anymore

…repository again rather than linking to a now outdated discussion thread on Signal-Android [0]. [0] https://github.com/signalapp/Signal-Android/issues/11101#iss...

comment by rvz · 2021-04-06 · in It looks like Signal isn't as open source as you thought it was anymore

…are open source[0], so unless the close source it, the arms race is mostly in commit speed. :) 0: https://github.com/signalapp/Signal-Android/commits/master

comment by zie · 2021-03-16 · in Telegram is booming but needs advertisers and $700M soon

https://github.com/signalapp/Signal-Android/search?q=video+g...

comment by nix23 · 2021-03-08 · in Does Signal use Jitsi in the background? If yes why can't I find this anywhere?

…private groups[4]. It's not perfect, but the data a malicious server could collect is limited. [1] https://github.com/signalapp/Signal-Android/tree/master/repr... [2] https://signal.org/blog/private-contact-discovery/ [3]…

comment by mfwoods · 2021-03-04 · in The Signal Server repository has not been updated since April 2020

…to decompile. They are very likely to get caught if they publish an update with a backdoor. [1] https://github.com/signalapp/Signal-Android/tree/master/repr...

comment by mfwoods · 2021-03-04 · in The Signal Server repository has not been updated since April 2020

…days ago - after months of people (politely) asking for it to be acknowledged as a serious concern. https://github.com/signalapp/Signal-Android/commit/0a29ffcf4...

comment by edent · 2021-02-09 · in A Statement on Recent Events Between Signal and the Anti-Censorship Community

…instructions for pulling the APK from your phone which was installed through the Play Store. https://github.com/signalapp/Signal-Android/tree/master/repr...

comment by tprynn · 2021-02-05 · in Help users in Iran reconnect to Signal

…dev here. We have reproducible build steps, so you actually can verify the code is the same :) https://github.com/signalapp/Signal-Android/tree/master/repr...

comment by greysonp · 2021-02-05 · in Help users in Iran reconnect to Signal

…to present itself as an option to handle signal.tube links, so DNS resolution isn't necessary: https://github.com/signalapp/Signal-Android/blob/master/app/...

comment by GranPC · 2021-02-05 · in Help users in Iran reconnect to Signal

Yes, they have some docs on GitHub for how to do it: https://github.com/signalapp/Signal-Android/wiki/How-to-buil... You can build the iOS version too for development: https://github.com/signalapp/Signal-iOS/blob/master/BUILDING... I…

comment by mariojv · 2021-02-05 · in Help users in Iran reconnect to Signal

…it was a client-side patch to handle 508 errors properly as well as doing exponential backoff. [1]: https://github.com/signalapp/Signal-Android/commit/c95f0fce6...

comment by cyphar · 2021-01-27 · in WhatsApp loses millions of users after terms update

…run matches the source [1] Is there a detail relating to the server that would invalidate this? [1] https://github.com/signalapp/Signal-Android/tree/master/repr...

comment by monokh · 2021-01-17 · in We can do better than Signal

…retried. List of handled HTTP exceptions (413, 401, 403, 409, 410, 411, 423, 499 and 508) is here: https://github.com/signalapp/Signal-Android/blob/2c1c6fab356... I personally would not repeat requests automatically by default on any HTTP…

comment by Daniel_sk · 2021-01-17 · in Signal Is Back

…app and millions of apps started retrying the connection at once. Judging from recent commits in https://github.com/signalapp/Signal-Android/commits/master " Surely a timely reminder for all of us: - Avoid infinite retry loops - Build…

comment by jez · 2021-01-17 · in Signal Is Up and Running

Signal started to handle 404 7 months ago and the 508 code 13 hours ago. ( https://github.com/signalapp/Signal-Android/blame/master/lib... strg+f 508)

comment by ju-st · 2021-01-16 · in Signal apps DDoS'ed their own server

…can guard features that are not yet ready to be activated." Here is the file with javadoc on top: https://github.com/signalapp/Signal-Android/blob/2c1c6fab356...

comment by Daniel_sk · 2021-01-16 · in Signal apps DDoS'ed their own server